[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] File layout for conformance tests



Agree with all of Olli's points. A new "constructors" subdirectory
sounds good. Factoring the tests to share code is essential for future
maintainability.

Note the 00_test_list.txt files throughout the repository. Please
follow the conventions, test your new tests in the top-level harness,
and add the --min-version 1.0.3 prefix to all of your tests, just for
bookkeeping reasons.

http://www.khronos.org/webgl/wiki/Using_Github_To_Contribute may help
in getting set up to submit pull requests.

Thanks for your contributions,

-Ken

On Fri, Jan 17, 2014 at 9:31 AM, Olli Etuaho <oetuaho@nvidia.com> wrote:
>
> "constructors" sounds okay to me. The misc directory has accumulated more than enough tests, and there might be room for some more constructor tests too. I'm not among the conformance suite admins, but I don't think that adding a new directory should be a sticking point in the review.
>
> I imagine that the tests will share a lot of common structure (at least vec/ivec/bvec should be practically the same), I'd try to implement them so that the code is generated based on a template, in a common js file in "resources".
>
> -Olli Etuaho
> ________________________________________
> From: owner-public_webgl@khronos.org [owner-public_webgl@khronos.org] On Behalf Of Tibor Ouden, den [tibordenouden@gmail.com]
> Sent: Friday, January 17, 2014 6:08 PM
> To: public_webgl@khronos.org
> Subject: [Public WebGL] File layout for conformance tests
>
>     In relation to this issue :
>     http://www.khronos.org/bugzilla/show_bug.cgi?id=1091
>     I want to add some conformance tests for constructors of the glsl data types.
>
>     The tests I am going to add test the validity of constructor expressions which contain more argument components compared
>     to the target data type, like :
>
>     vec2 v2 = vec2(vec3); // valid
>     vec2 v2 = vec2(float, vec3); // valid
>     vec2 v2 = vec2(float, float, vec3); // invalid, none of the components of the last argument are used by the target type
>
>     (See 5.4.2 Vector and Matrix Constructors in OpenGL ES Shading Language)
>
>     There will be several tests for valid and invalid expressions.
>     There will tests for all data types : vecx, ivecx, bvecx, matx; x : [2 - 4]
>
>     I assume the tests will be put in :
>     WebGL\sdk\tests\conformance\glsl.
>
>     In the glsl directory there are the following directories :
>     bugs
>     functions
>     implicit
>     literals
>     matrices
>     misc
>     reserved
>     samplers
>     variables
>
>
>     I think one file per data type make sence. But where should I put them ?
>     For matrices there is already a directory, So I could put the matrix tests in that directory and create a new one : vectors and put the vector
>     tests in that one.
>
>     I am inclined to create a new directory : constructors, and put all tests in there.
>
>     Otherways to layout the tests ?
>     misc is always an option :-)
>
>     I would like to get some advice on the appropriate way to add these tests to the
>     conformance suite.
>
>     Regards,
>
>     Tibor den Ouden
>
>
> -----------------------------------------------------------
> You are currently subscribed to public_webgl@khronos.org.
> To unsubscribe, send an email to majordomo@khronos.org with
> the following command in the body of your email:
> unsubscribe public_webgl
> -----------------------------------------------------------
>

-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------