[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] Tolerances in video upload tests

Looks good to me.

On Fri, Mar 15, 2013 at 4:03 PM, Kenneth Russell <kbr@google.com> wrote:
Recently hardware-accelerated video decoding was enabled in Chrome. The difference in behavior between the hardware and software video decoding path caused the video-related WebGL conformance tests to start failing, because, as it turns out, those tests have to date always required an exact pixel match, which is a bug in the test. Video encoding is lossy, and exact pixel matches can not be guaranteed.

I've uploaded a pull request to increase the tolerances in these tests. The new tolerance is low enough to ensure correct colors, but above what was required to make these tests pass with the particular vendor's hardware decoding implementation.


This pull request affects the 1.0.1, 1.0.2, and top of tree conformance suites.

Please post any comments about this change to the list.