[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] Please review getShaderPrecisionFormat call



On Thu, Dec 1, 2011 at 12:51 PM, Chris Marrin <cmarrin@apple.com> wrote:
>>> I've updated the spec (https://www.khronos.org/registry/webgl/specs/latest/) with the getShaderPrecisionFormat call. I also added a WebGLShaderPrecisionFormat object to hold the returned values. Please review

Thanks, Chris. Looks good overall.

On Thu, Dec 1, 2011 at 2:39 PM, Glenn Maynard <glenn@zewt.org> wrote:
> On Thu, Dec 1, 2011 at 5:30 PM, James Robinson <jamesr@google.com> wrote:
>>
>> It looks like the return value here is an object, not a value.  Thus it
>> needs to define the behavior for multiple calls (is the same object
>> returned, or a new object every time) and have tests for it.  Based on our
>> previous discussion I think the answer is that it always returns a new
>> JavaScript object.
>
>
> That's what most JS APIs should do.  I'd suggest "Return a new
> WebGLShaderPrecisionFormat describing the range and precision for the
> specified shader numeric format."

Thanks Glenn and James. The spec for getShaderPrecisionFormat's been
tweaked, and also getUniformLocation while I was at it.

-Ken

-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------