[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] Odd error trying to initialize shaders in chrome dev




Yeah - that's a classic example - the shader contains a lawyer's
disclaimer containing two sets of double quotes - and a threat of 10 years
at Guantanamo if you remove it.

Removing all of the quotes from my shaders gets the game running in Chrome
again.  I still need someone to test on Safari.

Anyway - it's getting fixed!   Yeaaaahhh!


  -- Steve

> Please find attached an example. I used the blinnphong shader from the
> O3D examples.
>
> Thanks for the help.
>
> On Thu, Jan 13, 2011 at 3:10 PM, Kenneth Russell <kbr@google.com> wrote:
>> WebKit bug filed as https://bugs.webkit.org/show_bug.cgi?id=52390 .
>> Will try to fix today.
>>
>> -Ken
>>
>> On Thu, Jan 13, 2011 at 12:04 PM,  <steve@sjbaker.org> wrote:
>>>
>>> Hell yes you need to "relax" that!  It's nuts that you can't use simple
>>> ASCII characters in comments.  I can't think of another language on the
>>> planet that doesn't allow it!  It would be a constant pain in the butt
>>> for
>>> programmers who just want to type a comment in normal, plain English
>>> who
>>> will forget once in a while and get some kind of cryptic error (EOF in
>>> shader - doesn't exactly convey "You have a quote in your comment").
>>>
>>> Not to mention things like company lawyers who demand that I place a
>>> very
>>> specific copyright/disclaimer at the top of every file - and if they
>>> happened to use a quote in that text, it could take a month and a
>>> thousand
>>> dollars in <s>blood-sucking</s> lawyer fees to get an alternative
>>> version
>>> without the quotes approved.  If you ever need to write a shader for
>>> the
>>> government...well, <s>don't</s> dont get me started on that!
>>>
>>> WebGL is fragile enough as it is - let's not make it unnecessarily
>>> worse.
>>>
>>> Anyway - I've removed the quotes from my shaders - but only under
>>> protest!
>>>
>>>  :-)
>>>
>>>  -- Steve
>>>
>>>> My best guess is the presence of the quote in the shader's comments.
>>>> Chrome and Safari have recently begun rejecting shaders that contain
>>>> characters outside the ESSL character set, even if they are in
>>>> comments. There's another ongoing thread discussing this change in
>>>> behavior.
>>>>
>>>> Perhaps we should relax this behavior. We could filter out comments
>>>> before testing the shader for characters outside the legal set.
>>>>
>>>> -Ken
>>>>
>>>> On Thu, Jan 13, 2011 at 9:25 AM,  <steve@sjbaker.org> wrote:
>>>>>
>>>>> Quite a few people have been seeing that error in my game too.
>>>>>
>>>>> Looks like a Chrome snafu.
>>>>>
>>>>>  -- Steve
>>>>>
>>>>>> I just noticed a weird error looking a some (not all) demos and my
>>>>>> app
>>>>>> using the latest chrome dev channel.
>>>>>>
>>>>>> Example where error occurs:
>>>>>>
>>>>>> http://industrialarithmetic.blogspot.com/2011/01/test.html
>>>>>>
>>>>>> the error I get is:
>>>>>> ERROR: 0:1: 'unexpected EOF' : syntax error
>>>>>>
>>>>>> Any changes to the way chrome reads shaders?
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> --
>>>>>> -----------------
>>>>>> Nicolas Kassis
>>>>>> -----------------------------------------------------------
>>>>>> You are currently subscribed to public_webgl@khronos.org.
>>>>>> To unsubscribe, send an email to majordomo@khronos.org with
>>>>>> the following command in the body of your email:
>>>>>> unsubscribe public_webgl
>>>>>> -----------------------------------------------------------
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -----------------------------------------------------------
>>>>> You are currently subscribed to public_webgl@khronos.org.
>>>>> To unsubscribe, send an email to majordomo@khronos.org with
>>>>> the following command in the body of your email:
>>>>> unsubscribe public_webgl
>>>>> -----------------------------------------------------------
>>>>>
>>>>>
>>>>
>>>> -----------------------------------------------------------
>>>> You are currently subscribed to public_webgl@khronos.org.
>>>> To unsubscribe, send an email to majordomo@khronos.org with
>>>> the following command in the body of your email:
>>>> unsubscribe public_webgl
>>>> -----------------------------------------------------------
>>>>
>>>>
>>>
>>>
>>>
>>
>
>
>
> --
> -----------------
> Nicolas Kassis
>



-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------