[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] New tests checked in, verifying that functions returning strings do return strings



FYI, r16792 fixes bug 587 which Ehsan reported apparently while working on the WebKit tests.

----- Original Message -----
> It's https://bugs.webkit.org/show_bug.cgi?id=77149 per the update to
> the Chromium bug. (Looks like you already found it.)
> 
> -Ken
> 
> On Mon, Jan 30, 2012 at 7:47 PM, Ehsan Akhgari
> <ehsan.akhgari@gmail.com> wrote:
> > What is the bug number? I'd like to try to write a patch for it.
> >
> > --
> > Ehsan
> > <http://ehsanakhgari.org/>
> >
> >
> >
> > On Mon, Jan 30, 2012 at 9:15 PM, Kenneth Russell <kbr@google.com>
> > wrote:
> >>
> >> Thanks for the patch. I commented on it -- there's an upstream bug
> >> filed against WebKit that would be much better to fix.
> >>
> >> -Ken
> >>
> >> On Sat, Jan 28, 2012 at 9:46 PM, Benoit Jacob <bjacob@mozilla.com>
> >> wrote:
> >> > Ehsan submitted a patch for it on
> >> > http://code.google.com/p/chromium/issues/detail?id=111337
> >> >
> >> > I'm not sure how to check the CC list for a Chromium bug, which
> >> > is why
> >> > I'm writing to this list about that.
> >> >
> >> > Cheers,
> >> > Benoit
> >> >
> >> > ----- Original Message -----
> >> >> On Thu, Jan 26, 2012 at 7:53 PM, Benoit Jacob
> >> >> <bjacob@mozilla.com>
> >> >> wrote:
> >> >> >
> >> >> >
> >> >> > ----- Original Message -----
> >> >> >> On Thu, Jan 26, 2012 at 3:30 PM, Benoit Jacob
> >> >> >> <bjacob@mozilla.com>
> >> >> >> wrote:
> >> >> >> >
> >> >> >> >
> >> >> >> > ----- Original Message -----
> >> >> >> >> On Thu, Jan 26, 2012 at 1:11 PM, Benoit Jacob
> >> >> >> >> <bjacob@mozilla.com>
> >> >> >> >> wrote:
> >> >> >> >> >
> >> >> >> >> >
> >> >> >> >> >
> >> >> >> >> > ----- Original Message -----
> >> >> >> >> >>
> >> >> >> >> >> Hello,
> >> >> >> >> >>
> >> >> >> >> >> this is just a heads-up about some new tests that were
> >> >> >> >> >> just
> >> >> >> >> >> checked
> >> >> >> >> >> in the conformance test suite.
> >> >> >> >> >>
> >> >> >> >> >> They check that functions that return DOMString in the
> >> >> >> >> >> IDL,
> >> >> >> >> >> actually
> >> >> >> >> >> return a JS string (and not e.g. null).
> >> >> >> >> >>
> >> >> >> >> >> The tests are in a new file,
> >> >> >> >> >> functions-returning-strings.html,
> >> >> >> >> >> plus a
> >> >> >> >> >> patch to the existing program-test.html.
> >> >> >> >> >>
> >> >> >> >> >> See:
> >> >> >> >> >> http://www.khronos.org/bugzilla/show_bug.cgi?id=582
> >> >> >> >> >>
> >> >> >> >> >> The revisions are r16739, r16741, r16742.
> >> >> >> >> >
> >> >> >> >> > Some more tests added in r16744.
> >> >> >> >>
> >> >> >> >> Thanks. Could you please add the new test to
> >> >> >> >> conformance/misc/00_test_list.txt?
> >> >> >> >
> >> >> >> > The only new test file is functions-returning-strings.html
> >> >> >> > and
> >> >> >> > it
> >> >> >> > is added to the test list. The new tests added in 16744
> >> >> >> > were
> >> >> >> > added
> >> >> >> > to that same file.
> >> >> >>
> >> >> >> Uh oh. It looks like my browser is returning an old cached
> >> >> >> copy of
> >> >> >> this test list, and shift-reloading the conformance tests
> >> >> >> does not
> >> >> >> fix
> >> >> >> the problem.
> >> >> >
> >> >> > Use a real browser ;-D
> >> >>
> >> >> Clearly!
> >> >>
> >> >> > Does this URL show you the updated test list?
> >> >> >
> >> >> > https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/misc/00_test_list.txt
> >> >>
> >> >> Yes, I had to directly load that file and then reload it in
> >> >> order to
> >> >> get Chromium to notice that it had been updated. Everything's
> >> >> working
> >> >> now.
> >> >>
> >> >> A search for "xhr bypass cache" turns up a bunch of interesting
> >> >> results for both Chrome and Firefox...
> >> >>
> >> >> -Ken
> >> >>
> >> >> > Benoit
> >> >> >
> >> >> >>
> >> >> >> -Ken
> >> >> >>
> >> >> >> > Benoit
> >> >> >> >
> >> >> >> >>
> >> >> >> >> -Ken
> >> >> >> >>
> >> >> >>
> >> >>
> >
> >
> 

-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------