[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Public WebGL] problematic more/ tests now part of 1.0.0 conformance suite



The more tests are required but I see Benoit's point that some of those tests might not be specific to WebGL and should be refactored.

Passing an empty img tag to gl.texImage2D seems like it should be defined
Checking for ImageData should probably not.

I'll look into refactoring those tests.

-g

On Mon, Feb 28, 2011 at 12:33 AM, Tim Johansson <timj@opera.com> wrote:

On 2011-02-27 17:45, Benoit Jacob wrote:
For what it's worth, I filed
   https://bugzilla.mozilla.org/show_bug.cgi?id=637077
and I now completely agree that we should add a proper ImageData interface, despite still not knowing whether that kind of thing is normative.

So this will probably be in Firefox 5; meanwhile, what I would like to know is whether the more/ directory is a requirement in order to be able to claim that we "pass the conformance test suite".
Yes, the tests in more are required. We all agreed in January that the more/ tests should be part of the conformance test suite as they found several important bugs in multiple implementations.

//Tim


Benoit

----- Original Message -----
Hi,

I noticed that the more/ directory was moved to conformance/ so I
guess that I really have to make us pass them now if we don't want to
look bad. But the quickCheckAPI.html test is giving me headaches:

* at quickCheckAPI.js:1050, we have this _expression_:

ximage instanceof ImageData

and it gives me this error: 'ImageData is not defined' in Firefox 4.
Do you think that's a bug in Firefox? I thought, perhaps wrongly, that
such type names were considered an internal thing.

* at quickCheckAPI.js:342, we have:

img = document.createElement('img');
img.width = w; img.height = h;

which creates an image with 'void' image data, which generates an
exception in Firefox 4 when passed to texImage2D, but the test expects
that to work. Here I guess it really is a gray area?

Unless you think that these are plain Firefox bugs, could we somehow
make it clear that more/ is not part of the conformance suite? Earlier
we had agreed to have the more/ tests not run by default by the online
runner, but I never took the time to write the patch (sorry).

Cheers,
Benoit
-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------
-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------

-----------------------------------------------------------
You are currently subscribed to public_webgl@khronos.org.
To unsubscribe, send an email to majordomo@khronos.org with
the following command in the body of your email:
unsubscribe public_webgl
-----------------------------------------------------------