Difference between revisions of "GLSL : common mistakes"

From OpenGL Wiki
Jump to navigation Jump to search
Line 27: Line 27:
==== Functions ====
==== Functions ====
Functions should look like this<br>
Functions should look like this<br>
vec4 myfunction(inout value1, in value2, in value3)<br>
vec4 myfunction(inout float value1, in vec3 value2, in vec4 value3)<br>
instead of<br>
instead of<br>
vec4 myfunction(value1, value2, value3)<br>
vec4 myfunction(float value1, vec3 value2, vec4 value3)<br>
==== Not Used ====
==== Not Used ====

Revision as of 14:00, 28 March 2008

Enable Or Not To Enable

With fixed pipeline, you needed to call glEnable(GL_TEXTURE_2D) to enable 2D texturing. You needed to call glEnable(GL_LIGHTING). Since shaders override these functionalities, you don't need to glEnable/glDisable. If you don't want texturing, you either need to write another shader that doesn't do texturing or you can attach a all white or all black texture, depending on your needs. You can also write one shader that does lighting and one that doesn't.

Things that are not overriden by shaders, like the alpha test, depth test, stencil test... calling glEnable/glDisable will have an effect.

Binding A Texture

When you compile and link your GLSL shader, the next step is to get uniform locations for your samplers (I'm talking about texture samplers) and setup the samplers. Some people do this
glUniformi(location, textureID)
You can't send a GL texture ID as your sampler. A sampler should be from 0 to the max number of texture image units.
To bind a texture, always use glBindTexture.


nVidia drivers are more relaxed. You could do
float myvalue = 0;
but this won't compile on other platforms. Use 0.0 instead.
Don't write 0.0f. GLSL is not C or C++.

float texel = texture2D(tex, texcoord);
The above is wrong since texture2D returns a vec4
Do this instead
float texel = float(texture2D(tex, texcoord));
float texel = texture2D(tex, texcoord).r;
float texel = texture2D(tex, texcoord).x;


Functions should look like this
vec4 myfunction(inout float value1, in vec3 value2, in vec4 value3)
instead of
vec4 myfunction(float value1, vec3 value2, vec4 value3)

Not Used

In the vertex shader
gl_TexCoord[0] = gl_MultiTexCoord0;
and in the fragment shader
vec4 texel = texture2D(tex, gl_TexCoord[0].xy);

zw isn't being used in the fs.

Easy Optimization

gl_TexCoord[0].x = gl_MultiTexCoord0.x;
gl_TexCoord[0].y = gl_MultiTexCoord0.y;

turns into
gl_TexCoord[0].xy = gl_MultiTexCoord0.xy;