Khronos Public Bugzilla
Bug 332 - small WebGL test harness improvements
small WebGL test harness improvements
Status: NEW
Product: WebGL
Classification: Unclassified
Component: Conformance Tests
unspecified
All All
: P3 normal
: ---
Assigned To: 3dweb Working Group email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-30 14:45 PDT by Benoit Jacob
Modified: 2010-07-30 15:10 PDT (History)
4 users (show)

See Also:


Attachments
some webgl test harness improvements (518 bytes, patch)
2010-07-30 14:45 PDT, Benoit Jacob
Details | Diff
some webgl test harness improvements (second try) (1.64 KB, patch)
2010-07-30 14:50 PDT, Benoit Jacob
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benoit Jacob 2010-07-30 14:45:33 PDT
Created attachment 46 [details]
some webgl test harness improvements

The attached patch does a couple of things:

* it makes the TestHarness constructor actually honor its filelistUrl parameter. Currently, this is ignored as the value 'test_list.xt' was hardcoded there (but was also passed by the test runner!)

* it renames test_list.txt to 00_test_list.txt as is already the filename used in the subdirectories. My motivation for that is that in Mozilla we are using Mochikit for our test framework, and it interpretes any file starting by test_ ... as a test. So please consider either this renaming or any other renaming of your choice, this would be very helpful to us.

* it adds the ability to configure the timeout delay for the tests, by calling setTimeoutDelay(). Currently, this is hard-coded to 3 seconds.

Is it OK to commit?
Comment 1 Benoit Jacob 2010-07-30 14:50:24 PDT
Created attachment 47 [details]
some webgl test harness improvements (second try)

Sorry, the first version of the patch was missing webgl-test-harness.js.

This patch still doesn't seem to show the file rename correctly, just trust me that it's renaming the file and not deleting it as it looks like :-)
Comment 2 Benoit Jacob 2010-07-30 14:51:15 PDT
Here's the output of svn st:

A  +    00_test_list.txt
D       test_list.txt
M       resources/webgl-test-harness.js
Comment 3 Kenneth Russell 2010-07-30 15:07:11 PDT
These changes look fine to me.
Comment 4 Benoit Jacob 2010-07-30 15:10:10 PDT
Thanks for the quick reply! committing.