Results 1 to 6 of 6

Thread: fixes for libKTX2.0

  1. #1
    Newbie
    Join Date
    Aug 2013
    Posts
    2

    fixes for libKTX2.0

    hey guys, here is my fork of libKTX on github:
    https://github.com/paroj/KTX

    this fixes compilation on linux and android and some compiler warnings. Hope to see this merged back into mainline.

  2. #2
    Super Moderator
    Join Date
    May 2008
    Posts
    18
    Thank you for the fixes. I will review them and merge them into the mainline. If you could provide a patch, that would result in them appearing in the mainline sooner. I will likely move the source to the Khronos github account but I first need to get the okay of the other members.

    Looking at GYP or CMake for the KTX code is on my TO DO list. What led you to choose CMake?
    Last edited by markc; 08-09-2013 at 01:22 PM. Reason: Fix typo

  3. #3
    Newbie
    Join Date
    Aug 2013
    Posts
    2
    I tried to keep the changes in separate commits, so you can cherry-pick the things you actually want to merge. If you want to get a patch from a commit on github, simply select a commit from the overview page.
    Then add ".patch" to the url, like this:
    https://github.com/paroj/KTX/commit/...ac2b77f8.patch

    I chose CMake as it seems to be the de-facto standard[1] in the C/C++ world. It is mature, cross platform and convinient to use. I did not hear about GYP before, but after a quick search it seems to be so esoteric system not used much outside of the chromium project.

    [1] en.wikipedia.org/wiki/CMake#Notable_applications (forum does not allow more than 2 links)

  4. #4
    Super Moderator
    Join Date
    May 2008
    Posts
    18
    @parojt thank you for the information. I'll get the changes in mainline as soon as I have a moment.

  5. #5
    Super Moderator
    Join Date
    May 2008
    Posts
    18
    I have received approval to move the KTX sources to Github. I'll post again when I have completed the move.

  6. #6
    Super Moderator
    Join Date
    May 2008
    Posts
    18

    Official KTX GitHub repository open

    Quote Originally Posted by markc View Post
    I have received approval to move the KTX sources to Github. I'll post again when I have completed the move.
    The sources are now up on GitHub at https://github.com/KhronosGroup/KTX.

    - - - Updated - - -

    Quote Originally Posted by parojt View Post
    hey guys, here is my fork of libKTX on github:
    https://github.com/paroj/KTX

    this fixes compilation on linux and android and some compiler warnings. Hope to see this merged back into mainline.
    Could you please submit pull requests for these fixes to the new KTX github repo. Thanks.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •