PDA

View Full Version : fixes for libKTX2.0



parojt
08-09-2013, 03:23 AM
hey guys, here is my fork of libKTX on github:
https://github.com/paroj/KTX

this fixes compilation on linux and android and some compiler warnings. Hope to see this merged back into mainline.

markc
08-09-2013, 01:21 PM
Thank you for the fixes. I will review them and merge them into the mainline. If you could provide a patch, that would result in them appearing in the mainline sooner. I will likely move the source to the Khronos github account but I first need to get the okay of the other members.

Looking at GYP or CMake for the KTX code is on my TO DO list. What led you to choose CMake?

parojt
08-12-2013, 02:20 AM
I tried to keep the changes in separate commits, so you can cherry-pick the things you actually want to merge. If you want to get a patch from a commit on github, simply select a commit from the overview page (https://github.com/paroj/KTX/commits/master).
Then add ".patch" to the url, like this:
https://github.com/paroj/KTX/commit/23ae000e845825683f254252d652057aac2b77f8.patch

I chose CMake as it seems to be the de-facto standard[1] in the C/C++ world. It is mature, cross platform and convinient to use. I did not hear about GYP before, but after a quick search it seems to be so esoteric system not used much outside of the chromium project.

[1] en.wikipedia.org/wiki/CMake#Notable_applications (forum does not allow more than 2 links)

markc
08-12-2013, 12:59 PM
@parojt thank you for the information. I'll get the changes in mainline as soon as I have a moment.

markc
10-01-2013, 12:12 AM
I have received approval to move the KTX sources to Github. I'll post again when I have completed the move.

markc
10-16-2013, 01:30 AM
I have received approval to move the KTX sources to Github. I'll post again when I have completed the move.
The sources are now up on GitHub at https://github.com/KhronosGroup/KTX.

- - - Updated - - -


hey guys, here is my fork of libKTX on github:
https://github.com/paroj/KTX

this fixes compilation on linux and android and some compiler warnings. Hope to see this merged back into mainline.

Could you please submit pull requests for these fixes to the new KTX github repo. Thanks.