582 2012-01-25 08:30:00 -0800 Add test checking that getProgramInfoLog returns a string 2012-01-26 12:55:01 -0800 1 1 1 Unclassified WebGL Conformance Tests unspecified All All RESOLVED FIXED P3 normal --- 1 bjacob 3dweb gman kbr zmo 1576 bjacob 2012-01-25 08:30:13 -0800 We seem to be missing a test checking that the return value of getProgramInfoLog is a string. The WebGL spec doesn't say anything special about getProgramInfoLog, but it returns a DOMString so it's unexpected for it to return null. Chromium sometimes returns null instead of a (possibly empty) string: http://code.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc&exact_package=chromium&type=cs&l=796 We have come across a practical application that didn't run because of that. 1577 bjacob 2012-01-25 08:34:11 -0800 See http://code.google.com/p/chromium/issues/detail?id=111337 1578 98 bjacob 2012-01-25 08:58:38 -0800 Created attachment 98 Check that the infolog is a string We should also check if similar tests are needed for other string-returning functions such as getShaderInfoLog. 1579 bjacob 2012-01-25 09:03:37 -0800 Hm, Chromium does pass this test here (does return empty strings). I wonder how to hit the case in http://code.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc&exact_package=chromium&type=cs&l=796 1580 bjacob 2012-01-25 09:07:57 -0800 (In reply to comment #3) > Hm, Chromium does pass this test here (does return empty strings). I wonder how > to hit the case in > > http://code.google.com/codesearch#OAMlx_jo-ck/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc&exact_package=chromium&type=cs&l=796 I'm told that this is because I'm on Linux and this bug only occurs on Windows and Mac. 1583 bjacob 2012-01-26 12:55:01 -0800 Fixed in r16739, r16741, r16742. 98 2012-01-25 08:58:00 -0800 2012-01-25 08:58:38 -0800 Check that the infolog is a string check-infolog-is-string text/plain 1066 bjacob SW5kZXg6IGNvbmZvcm1hbmNlL3Byb2dyYW1zL3Byb2dyYW0tdGVzdC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGNvbmZvcm1hbmNlL3Byb2dyYW1zL3Byb2dyYW0tdGVzdC5odG1sCShyZXZpc2lvbiAxNjcw MykKKysrIGNvbmZvcm1hbmNlL3Byb2dyYW1zL3Byb2dyYW0tdGVzdC5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC0xOTgsOCArMTk4LDEzIEBACiAgICAgICAgIGlmIChnbC5nZXRFcnJvcigpICE9IGds Lk5PX0VSUk9SKQogICAgICAgICAgICAgYXNzZXJ0TXNnKGZhbHNlLCAidW5leHBlY3RlZCBlcnJv ciBpbiBsaW5rUHJvZ3JhbSgpIik7CiAgICAgICAgIGFzc2VydE1zZyhnbC5nZXRQcm9ncmFtUGFy YW1ldGVyKHByb2csIGdsLkxJTktfU1RBVFVTKSA9PSBleHBlY3RlZF9zdGF0dXMsIGVycm1zZyk7 CisgICAgICAgIHZhciBpbmZvbG9nID0gZ2wuZ2V0UHJvZ3JhbUluZm9Mb2cocHJvZyk7CisgICAg ICAgIGlmIChnbC5nZXRFcnJvcigpICE9IGdsLk5PX0VSUk9SKQorICAgICAgICAgICAgYXNzZXJ0 TXNnKGZhbHNlLCAidW5leHBlY3RlZCBlcnJvciBpbiBnZXRQcm9ncmFtSW5mb0xvZygpIik7Cisg ICAgICAgIGlmICh0eXBlb2YoaW5mb2xvZykgIT0gInN0cmluZyIpCisgICAgICAgICAgICBhc3Nl cnRNc2coZmFsc2UsICJnZXRQcm9ncmFtSW5mb0xvZygpIGRpZCBub3QgcmV0dXJuIGEgc3RyaW5n Iik7CiAgICAgICAgIGlmIChleHBlY3RlZF9zdGF0dXMgPT0gdHJ1ZSAmJiBnbC5nZXRQcm9ncmFt UGFyYW1ldGVyKHByb2csIGdsLkxJTktfU1RBVFVTKSA9PSBmYWxzZSkKLSAgICAgICAgICAgIGRl YnVnKGdsLmdldFByb2dyYW1JbmZvTG9nKHByb2cpKTsKKyAgICAgICAgICAgIGRlYnVnKGluZm9s b2cpOwogICAgICAgICBpZiAoZ2wuZ2V0RXJyb3IoKSAhPSBnbC5OT19FUlJPUikKICAgICAgICAg ICAgIGFzc2VydE1zZyhmYWxzZSwgInVuZXhwZWN0ZWQgZXJyb3IgaW4gZ2V0UHJvZ3JhbVBhcmFt ZXRlcigpIik7CiAgICAgICAgIGdsLnVzZVByb2dyYW0ocHJvZyk7Cg==