296 2010-04-26 08:41:00 -0700 cl.hpp: reference counting bug 2011-08-30 09:17:08 -0700 1 1 1 Unclassified OpenCL Header Files 1.0 All All RESOLVED FIXED P3 normal --- 1 markus.grabner ntrevett bgaster sschuberth opencl 918 markus.grabner 2010-04-26 08:41:16 -0700 <Please comment on your experience with the C++ bindings to OpenCL 1.0 here, including any bugs you encounter as well as suggestions for improvement. If you are having problems, please try to provide a complete example including source code demonstrating the problem as well as describing the OS, C++ compiler, and compiler options used.> 919 markus.grabner 2010-04-26 08:51:28 -0700 (In reply to comment #0) > <Please comment on your experience with the C++ bindings to OpenCL 1.0 here, > including any bugs you encounter as well as suggestions for improvement. If > you are having problems, please try to provide a complete example including > source code demonstrating the problem as well as describing the OS, C++ > compiler, and compiler options used.> Sorry, didn't expect that clicking the back button discards the text, so here it is: cl::CommandQueue::getInfo<CL_QUEUE_CONTEXT>() doesn't increase the reference count of the cl::Context object returned by this method. This results in a program crash when the destructur is called for the unreferenced instance. The problem probably exists for other getInfo<...> variants since the code is shared. This file demonstrates the problem. The program crashes in ReferenceHandler<cl_context>::release(), which is invoked from cl::Context::~Context(). If the context's reference count is increased explicitly (by setting "#if 1" in line 47), the program finishes without error. 920 40 markus.grabner 2010-04-26 08:52:30 -0700 Created attachment 40 demonstrate reference counting bug 921 bgaster 2010-04-26 10:40:45 -0700 This is a known problem and something we are working on, unlike many of the other bugs it does not have a straightforward solution. 922 markus.grabner 2010-04-27 03:26:53 -0700 I see. Is there a public discussion on this issue elsewhere? I would like to contribute since the workaround I'm currently using is quite ugly :-) 923 bgaster 2010-04-27 10:41:10 -0700 There is general discussion of the C++ bindings on the OpenCL forum here: http://www.khronos.org/message_boards/viewtopic.php?f=28&t=1415 927 41 markus.grabner 2010-05-03 11:38:03 -0700 Created attachment 41 proposed patch for reference counting bug This is a proposed patch for this issue: *) define a template function "fixReferenceCount()" which does nothing *) overload this function for all relevant types (e.g., cl::Context), and call their retain() method *) call "fixReferenceCount()" for data returned by the native OpenCL functions (in GetInfoHelper::get()) 1188 sschuberth 2011-01-07 07:08:21 -0800 This post says reference counting was fixed: http://www.khronos.org/message_boards/viewtopic.php?p=7692#p7692 Can the OP confirm? 1461 bgaster 2011-08-30 09:17:08 -0700 Reference counting is fixed and so closing. 40 2010-04-26 08:52:00 -0700 2010-04-26 08:52:30 -0700 demonstrate reference counting bug opencl_bug.cpp text/plain 1750 markus.grabner LyoNCg0KCSBjbDo6Q29tbWFuZFF1ZXVlOjpnZXRJbmZvPENMX1FVRVVFX0NPTlRFWFQ+KCkgZG9l c24ndCBpbmNyZWFzZSB0aGUNCgkgcmVmZXJlbmNlIGNvdW50IG9mIHRoZSBjbDo6Q29udGV4dCBv YmplY3QgcmV0dXJuZWQgYnkgdGhpcyBtZXRob2QuIFRoaXMNCgkgcmVzdWx0cyBpbiBhIHByb2dy YW0gY3Jhc2ggd2hlbiB0aGUgZGVzdHJ1Y3R1ciBpcyBjYWxsZWQgZm9yIHRoZQ0KCSB1bnJlZmVy ZW5jZWQgaW5zdGFuY2UuIFRoZSBwcm9ibGVtIHByb2JhYmx5IGV4aXN0cyBmb3Igb3RoZXIgZ2V0 SW5mbzwuLi4+DQoJIHZhcmlhbnRzIHNpbmNlIHRoZSBjb2RlIGlzIHNoYXJlZC4NCg0KCSBUaGlz IGZpbGUgZGVtb25zdHJhdGVzIHRoZSBwcm9ibGVtLiBUaGUgcHJvZ3JhbSBjcmFzaGVzIGluIA0K CSBSZWZlcmVuY2VIYW5kbGVyPGNsX2NvbnRleHQ+OjpyZWxlYXNlKCksIHdoaWNoIGlzIGludm9r ZWQgZnJvbQ0KCSBjbDo6Q29udGV4dDo6fkNvbnRleHQoKS4gSWYgdGhlIGNvbnRleHQncyByZWZl cmVuY2UgY291bnQgaXMgaW5jcmVhc2VkDQoJIGV4cGxpY2l0bHkgKGJ5IHNldHRpbmcgIiNpZiAx IiBpbiBsaW5lIDQ3KSwgdGhlIHByb2dyYW0gZmluaXNoZXMgd2l0aG91dA0KCSBlcnJvci4NCg0K Ki8NCg0KI2luY2x1ZGUgPGlvc3RyZWFtPg0KDQojZGVmaW5lIF9fQ0xfRU5BQkxFX0VYQ0VQVElP TlMNCiNpbmNsdWRlIDxDTC9jbC5ocHA+DQoNCnVzaW5nIG5hbWVzcGFjZSBzdGQ7DQoNCg0KaW50 DQp0ZXN0X29wZW5jbF9idWcoKQ0Kew0KCXRyeSB7DQoJCS8vIGdldCBsaXN0IG9mIHBsYXRmb3Jt cyBhbmQgZGV2aWNlczoNCgkJdmVjdG9yPGNsOjpQbGF0Zm9ybT4gcGxhdGZvcm1zOw0KCQl2ZWN0 b3I8Y2w6OkRldmljZT4gZGV2aWNlczsNCgkJY2w6OlBsYXRmb3JtOjpnZXQoJnBsYXRmb3Jtcyk7 DQoJCXBsYXRmb3Jtc1swXS5nZXREZXZpY2VzKENMX0RFVklDRV9UWVBFX0FMTCwgJmRldmljZXMp Ow0KCQkNCgkJLy8gY3JlYXRlIGEgY29udGV4dDoNCgkJY2w6OkNvbnRleHQgY29udGV4dChkZXZp Y2VzKTsNCg0KCQkvLyBjcmVhdGUgYSBjb21tYW5kIHF1ZXVlOg0KCQljbDo6Q29tbWFuZFF1ZXVl IHF1ZXVlKGNvbnRleHQsIGRldmljZXNbMF0sIDApOw0KDQoJCS8vIHByaW50IGN1cnJlbnQgY29u dGV4dCByZWZlcmVuY2UgY291bnQ6DQoJCWNvdXQgPDwgInJlZiBjb3VudCA9ICIgPDwgY29udGV4 dC5nZXRJbmZvPENMX0NPTlRFWFRfUkVGRVJFTkNFX0NPVU5UPigpIDw8IGVuZGw7DQoNCgkJLy8g YWNjZXNzIGNvbnRleHQgYXNzb2NpYXRlZCB3aXRoIGNvbW1hbmQgcXVldWU6DQoJCWNsOjpDb250 ZXh0IGNvbnRleHQyKHF1ZXVlLmdldEluZm88Q0xfUVVFVUVfQ09OVEVYVD4oKSk7DQoNCiNpZiAw DQoJCS8vIElmIHRoZSBjb250ZXh0J3MgcmVmZXJlbmNlIGNvdW50IGlzIGluY3JlYXNlZCBleHBs aWNpdGx5IGF0IHRoaXMgcG9pbnQsDQoJCS8vIHRoZSBwcm9ncmFtIGZpbmlzaGVzIHdpdGhvdXQg ZXJyb3I6DQoJCTo6Y2xSZXRhaW5Db250ZXh0KGNvbnRleHQyKCkpOw0KI2VuZGlmDQoNCgkJY291 dCA8PCAicmVmIGNvdW50ID0gIiA8PCBjb250ZXh0LmdldEluZm88Q0xfQ09OVEVYVF9SRUZFUkVO Q0VfQ09VTlQ+KCkgPDwgZW5kbDsNCgl9DQoJY2F0Y2goY2w6OkVycm9yIGVycikgew0KCQljZXJy IDw8ICJFUlJPUjogIiA8PCBlcnIud2hhdCgpIDw8ICIoIiA8PCBlcnIuZXJyKCkgPDwgIikiIDw8 IGVuZGw7DQoJfQ0KDQoJcmV0dXJuIEVYSVRfU1VDQ0VTUzsNCn0NCg== 41 2010-05-03 11:38:00 -0700 2010-05-03 11:38:03 -0700 proposed patch for reference counting bug cl.hpp.patch text/plain 1641 markus.grabner LS0tIFI6L0FUSSBTdHJlYW0vaW5jbHVkZS9DTC9jbC0xLjAuaHBwCVRodSBBcHIgMjkgMTE6NDY6 NTcgMjAxMA0KKysrIFI6L0FUSSBTdHJlYW0vaW5jbHVkZS9DTC9jbC5ocHAJTW9uIE1heSAwMyAx ODozMDo1MiAyMDEwDQpAQCAtMzM1LDYgKzMzNSw5IEBADQogY2xhc3MgQ29udGV4dDsNCiBjbGFz cyBDb21tYW5kUXVldWU7DQogY2xhc3MgTWVtb3J5Ow0KK2NsYXNzIFNhbXBsZXI7DQorY2xhc3Mg S2VybmVsOw0KK2NsYXNzIEV2ZW50Ow0KIA0KICNpZiBkZWZpbmVkKF9fQ0xfRU5BQkxFX0VYQ0VQ VElPTlMpDQogI2luY2x1ZGUgPGV4Y2VwdGlvbj4NCkBAIC04MjQsNyArODI3LDkgQEANCiAgICAg c3RhdGljIGNsX2ludA0KICAgICBnZXQoRnVuY3RvciBmLCBjbF91aW50IG5hbWUsIFQqIHBhcmFt KQ0KICAgICB7DQotICAgICAgICByZXR1cm4gZihuYW1lLCBzaXplb2YoVCksIHBhcmFtLCBOVUxM KTsNCisgICAgICAgIGNsX2ludCByZXQgPSBmKG5hbWUsIHNpemVvZihUKSwgcGFyYW0sIE5VTEwp Ow0KKwkJZml4UmVmZXJlbmNlQ291bnQocGFyYW0pOw0KKwkJcmV0dXJuIHJldDsNCiAgICAgfQ0K IH07DQogDQpAQCAtMTIxNiw2ICsxMjIxLDE0IEBADQogICAgIHsNCiAgICAgICAgIHJldHVybiBS ZWZlcmVuY2VIYW5kbGVyPGNsX3R5cGU+OjpyZWxlYXNlKG9iamVjdF8pOw0KICAgICB9DQorDQor CWZyaWVuZCB2b2lkIGZpeFJlZmVyZW5jZUNvdW50KENvbnRleHQgKnBhcmFtKTsNCisJZnJpZW5k IHZvaWQgZml4UmVmZXJlbmNlQ291bnQoQ29tbWFuZFF1ZXVlICpwYXJhbSk7DQorCWZyaWVuZCB2 b2lkIGZpeFJlZmVyZW5jZUNvdW50KE1lbW9yeSAqcGFyYW0pOw0KKwlmcmllbmQgdm9pZCBmaXhS ZWZlcmVuY2VDb3VudChTYW1wbGVyICpwYXJhbSk7DQorCWZyaWVuZCB2b2lkIGZpeFJlZmVyZW5j ZUNvdW50KFByb2dyYW0gKnBhcmFtKTsNCisJZnJpZW5kIHZvaWQgZml4UmVmZXJlbmNlQ291bnQo S2VybmVsICpwYXJhbSk7DQorCWZyaWVuZCB2b2lkIGZpeFJlZmVyZW5jZUNvdW50KEV2ZW50ICpw YXJhbSk7DQogfTsNCiANCiAjaWYgZGVmaW5lZChfX0NMX0VOQUJMRV9FWENFUFRJT05TKQ0KQEAg LTczMzUsNiArNzM0OCwyNCBAQA0KICAgICAgICAgJmV2ZW50KTsNCiANCiAgICAgcmV0dXJuIGV2 ZW50Ow0KK30NCisNCituYW1lc3BhY2UgZGV0YWlsDQorew0KKyNkZWZpbmUgRklYX1JFRkVSRU5D RV9DT1VOVChUKSBcDQorc3RhdGljIGlubGluZSB2b2lkIGZpeFJlZmVyZW5jZUNvdW50KFQgKnBh cmFtKSBcDQoreyBcDQorCXBhcmFtLT5yZXRhaW4oKTsgXA0KK30NCit0ZW1wbGF0ZSA8dHlwZW5h bWUgVD4gaW5saW5lIHZvaWQgZml4UmVmZXJlbmNlQ291bnQoVCAqcGFyYW0pIHt9DQorRklYX1JF RkVSRU5DRV9DT1VOVChDb250ZXh0KTsNCitGSVhfUkVGRVJFTkNFX0NPVU5UKENvbW1hbmRRdWV1 ZSk7DQorRklYX1JFRkVSRU5DRV9DT1VOVChNZW1vcnkpOw0KK0ZJWF9SRUZFUkVOQ0VfQ09VTlQo U2FtcGxlcik7DQorRklYX1JFRkVSRU5DRV9DT1VOVChQcm9ncmFtKTsNCitGSVhfUkVGRVJFTkNF X0NPVU5UKEtlcm5lbCk7DQorRklYX1JFRkVSRU5DRV9DT1VOVChFdmVudCk7DQorI3VuZGVmIEZJ WF9SRUZFUkVOQ0VfQ09VTlQNCiB9DQogDQogI3VuZGVmIF9fRVJSX1NUUg0K